martin-g commented on a change in pull request #359: Wicket js cleanup
URL: https://github.com/apache/wicket/pull/359#discussion_r282458532
##########
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
##########
@@ -1143,23 +1085,9 @@
e.style.zIndex = Wicket.Window.Mask.zIndex;
Review comment:
Lately there are no many new tickets for ModalWindow but there are several
old ones in JIRA which no one cared to work on, me included.
I'm +1 to deprecate it but keep it around. The deprecation is just to tell
the users "We don't want to maintain it anymore". But I think we should keep it
for the ones which use it without problems. Migrating to another modal
(Bootstrap or anything) is an adventure on its own.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
