andruhon commented on a change in pull request #359: Wicket js cleanup
URL: https://github.com/apache/wicket/pull/359#discussion_r282781933
 
 

 ##########
 File path: 
wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
 ##########
 @@ -1143,23 +1085,9 @@
 
                                e.style.zIndex = Wicket.Window.Mask.zIndex;
 
 Review comment:
   Well, true. But it won't even be included in the list by technical team. At 
least that's what happened to myself in the past, I considered wicket but then 
was scared away by demos and wicket-ajax-jquery, so I didn't include it into 
the list. Also necessity to include 'unsafe-eval' into csp might drop chances 
of approval to zero if there's a security team present.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to