svenmeier commented on issue #361: WICKET-6666 initial checkin of new 
ModalDialog
URL: https://github.com/apache/wicket/pull/361#issuecomment-492684806
 
 
   Hi Igor,
   
   > my only word of caution is that a big reason why the old modal window was 
such a mess and so hard to maintain is because we put a ton of features into it 
that only a small percentage of people used, i would try to keep this one as 
thin as possible.
   
   I fully agree, most projects will have their special requirements anyway. 
This is why the new ModalDialog should rather be a "best practice" 
implementation instead of a "one fits all" solution.
   
   Sven

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to