I see it was reintroduced... On Thu, May 30, 2019 at 9:29 PM Ernesto Reinaldo Barreiro < [email protected]> wrote:
> https://issues.apache.org/jira/browse/WICKET-6672 > > On Thu, May 30, 2019 at 1:04 PM Ernesto Reinaldo Barreiro < > [email protected]> wrote: > >> + 1 then. I will create issue later on + PR >> >> On Thu, May 30, 2019 at 1:02 PM Andrea Del Bene <[email protected]> >> wrote: >> >>> I see your point. As you suggested you can create an issue and PR for >>> this. >>> I think we could work on it later without blocking this release. >>> >>> On Thu, May 30, 2019 at 11:53 AM Ernesto Reinaldo Barreiro < >>> [email protected]> wrote: >>> >>> > Hi Andrea, >>> > >>> > Migaring is not hard... it is annoying because I'm maintaining this >>> branch >>> > in parallel to our production 8..x branch. I perfectly understand the >>> > reasons. But as user I would prefer to have also the previous >>> constructors, >>> > but deprecated. As far as I can see Duration is not deprecated in 8.x. >>> And >>> > I thought wicket approach was deprecate in one version and remove in >>> next. >>> > >>> > On Thu, May 30, 2019 at 12:37 PM Andrea Del Bene <[email protected] >>> > >>> > wrote: >>> > >>> > > Hi Ernesto and thank you for you very quick feedback. First, let me >>> > explain >>> > > why we introduced such a huge API break. To handle time entities >>> Wicket >>> > was >>> > > using custom classes Duration and Time from package >>> > > org.apache.wicket.util.time. These were probably added in earlier >>> > versions >>> > > of Wicket taking them (I guess...) from other libraries like Joda >>> Time. >>> > > Since Java 8 both Duration and Time have a corresponding standard >>> class >>> > > which is functionally equivalent: java.time.Duration and >>> > java.time.Instant. >>> > > So it was quite natural to evolve the code base getting rid of the >>> old >>> > > legacy classes we used. I understand that adapting your code to this >>> > change >>> > > is not so pleasant (to say the least), but I'd like to know how hard >>> > would >>> > > be to migrate your code from old Duration class to >>> java.time.Duration. >>> > > Ideally this should be quite straightforward as most of the time it >>> > should >>> > > be just a one-to-one textual replacing as shown here: >>> > > https://issues.apache.org/jira/browse/WICKET-6662 >>> > > >>> > > Let me know what you think and thank you again. >>> > > >>> > > On Thu, May 30, 2019 at 9:59 AM Ernesto Reinaldo Barreiro < >>> > > [email protected]> wrote: >>> > > >>> > > > Or better ISSUE + PR? >>> > > > >>> > > > On Thu, May 30, 2019 at 10:57 AM Ernesto Reinaldo Barreiro < >>> > > > [email protected]> wrote: >>> > > > >>> > > > > I understand. Shall I create an issue for this? >>> > > > > >>> > > > > On Thu, May 30, 2019 at 10:27 AM Maxim Solodovnik < >>> > > [email protected]> >>> > > > > wrote: >>> > > > > >>> > > > >> I found this non-blocker since this is milestone release >>> > > > >> >>> > > > >> On Thu, 30 May 2019 at 13:26, Ernesto Reinaldo Barreiro < >>> > > > >> [email protected]> >>> > > > >> wrote: >>> > > > >> >>> > > > >> > Hi, >>> > > > >> > >>> > > > >> > I'm trying to test M2 with our APP and the first thing I >>> noticed >>> > is >>> > > > >> > Duration has been deprecated and all tiemer related classes no >>> > > longer >>> > > > >> > accept wicket duration. IMHO this is not nice for end users... >>> > i.e. >>> > > > now >>> > > > >> my >>> > > > >> > code does not compile and I have to keep diverging branches to >>> > test. >>> > > > It >>> > > > >> > would be nicer if wicket duration is still supported but those >>> > > > >> > constructors/methods are deprecated. My vote is non binding >>> but I >>> > > > would >>> > > > >> > vote >>> > > > >> > >>> > > > >> > -1 >>> > > > >> > >>> > > > >> > >>> > > > >> > On Thu, May 30, 2019 at 7:59 AM Maxim Solodovnik < >>> > > > [email protected]> >>> > > > >> > wrote: >>> > > > >> > >>> > > > >> > > +1 >>> > > > >> > > >>> > > > >> > > tested: >>> > > > >> > > 1) signatures >>> > > > >> > > 2) build from sources >>> > > > >> > > 3) wicketstuff: build and examples >>> > > > >> > > 4) our main application >>> > > > >> > > >>> > > > >> > > On Thu, 30 May 2019 at 04:51, Andrea Del Bene < >>> > > [email protected] >>> > > > > >>> > > > >> > > wrote: >>> > > > >> > > >>> > > > >> > > > This is a vote to release Apache Wicket 9.0.0-M2 >>> > > > >> > > > >>> > > > >> > > > Please download the source distributions found in our >>> staging >>> > > area >>> > > > >> > > > linked below. >>> > > > >> > > > >>> > > > >> > > > I have included the signatures for both the source >>> archives. >>> > > This >>> > > > >> vote >>> > > > >> > > > lasts for 72 hours minimum. >>> > > > >> > > > >>> > > > >> > > > [ ] Yes, release Apache Wicket 9.0.0-M2 >>> > > > >> > > > [ ] No, don't release Apache Wicket 9.0.0-M2, because ... >>> > > > >> > > > >>> > > > >> > > > Distributions, changelog, keys and signatures can be >>> found at: >>> > > > >> > > > >>> > > > >> > > > >>> https://dist.apache.org/repos/dist/dev/wicket/9.0.0-M2 >>> > > > >> > > > >>> > > > >> > > > Staging repository: >>> > > > >> > > > >>> > > > >> > > > >>> > > > >> > >>> > > > >> >>> > > > >>> > >>> https://repository.apache.org/content/repositories/orgapachewicket-1126/ >>> > > > >> > > > >>> > > > >> > > > The binaries are available in the above link, as are a >>> staging >>> > > > >> > > > repository for Maven. Typically the vote is on the >>> source, but >>> > > > >> should >>> > > > >> > > > you find a problem with one of the binaries, please let me >>> > > know, I >>> > > > >> can >>> > > > >> > > > re-roll them some way or the other. >>> > > > >> > > > >>> > > > >> > > > Staging git repository data: >>> > > > >> > > > >>> > > > >> > > > Repository: [email protected]:bitstorm/wicket.git >>> > > > >> > > > Branch: build/wicket-9.0.0-M2 >>> > > > >> > > > Release tag: rel/wicket-9.0.0-M2 >>> > > > >> > > > >>> > > > >> > > > >>> > > > >> > > > >>> > > > >> > >>> > > > >>> > >>> ======================================================================== >>> > > > >> > > > >>> > > > >> > > > The signatures for the source release artefacts: >>> > > > >> > > > >>> > > > >> > > > >>> > > > >> > > > Signature for apache-wicket-9.0.0-M2.zip: >>> > > > >> > > > >>> > > > >> > > > -----BEGIN PGP SIGNATURE----- >>> > > > >> > > > >>> > > > >> > > > >>> > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlzuv10ACgkQh48B+qjT >>> > > > >> > > > >>> > VuHJyRAAi0Lzsl1sLoqErPqEfhXdEydVVbrLBauObOQjimev29mrtijLiZMY2Ie8 >>> > > > >> > > > >>> > zcEqc8Jk8x6ZRyPln2oH18HyT7dbzxdAM/QSuqHYl6XWwIH97Bb8U87RYrR1YYgP >>> > > > >> > > > >>> > 4gL24rsv/OSe1NInMJYbykhoh41g9pKfbbLun7cGv6YK3oYNUYUBs2GCvoknxb+u >>> > > > >> > > > >>> > /GZFLB06fArYGVbd3cmNdySqQhw71xxrw/R4D8wO/282J2U2HS65W5dqKXIwBRWL >>> > > > >> > > > >>> > 8e0HLiKc5vvziB3NsQ4YAQ4tBgoATx6GY3UYyQxanVL6B4O6L4Sup+tFL+m4WcyJ >>> > > > >> > > > >>> > 7jq4UMasZD51sDGwbxIF0MubgwocnxsfT1B3vZgFw2bTAq+gJ0pvlZETA8WUc/T8 >>> > > > >> > > > >>> > t1C+KyAG2TX8QNEpCJfPKExH6brqt4sMdEW6c443xfA/if4y7PdGKOf3dnQ5lqtP >>> > > > >> > > > >>> > Ncd1CQ7ia1LNG7RYVCEA1HYmSAiZy/C5ZVS891vqHCKV9/qoxupQf9ii5UsUmHqm >>> > > > >> > > > >>> > tez7M9w46KVjmgpyuCSfBIvtCdOsm94Hhd0x2vcs0tHpqgm93T1a3fddxKfSbMj5 >>> > > > >> > > > >>> > S21of/LZmvuQp3NJFES2YOCBduMgZY7I3YHCcKYLrEub5gjG16b8CR8qJzd36YoU >>> > > > >> > > > MFbuQDgb0l4tT8ZTIqqhfeCvyw4ntevwcgRJoJmyctTrwnq1Hsg= >>> > > > >> > > > =eW0h >>> > > > >> > > > -----END PGP SIGNATURE----- >>> > > > >> > > > >>> > > > >> > > > Signature for apache-wicket-9.0.0-M2.tar.gz: >>> > > > >> > > > >>> > > > >> > > > -----BEGIN PGP SIGNATURE----- >>> > > > >> > > > >>> > > > >> > > > >>> > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlzuv10ACgkQh48B+qjT >>> > > > >> > > > >>> > VuHnqQ//Z3LKl0tfpSxcXXywTQTFaT3IKPIOwV0wf/30hAgQF24TUiZ/Bhm7kl5L >>> > > > >> > > > >>> > PnkCM/r06Q7aSOgzb+vCyVDN60S4hPnUXP5pPPBoHhTyqJ6syL2uQDeMYoYd2ySw >>> > > > >> > > > >>> > GGT2biUO6b0DXzHVKi58wLJ2YHvLq0XlTL0VBflcjv+ASzfBNH80yAfA6Ti2M0IK >>> > > > >> > > > >>> > IvWqbGZcW8nbu6U4jQhmjoyduqzRXM8tVZZ3CZwiJpQtKKJ/EISqFZxgpbEQkkF4 >>> > > > >> > > > >>> > 9FNVOYk4Y825F9B2P5Yi3P/uC3XX9LHf+olyEpVqUlzhyWZ2F8u1YEwkZ1SEsO0u >>> > > > >> > > > >>> > kVyIaEbVgwhWEBx6Digrg8hiR3rsFh7ROEJjtR5JFQ82b35zpuM7VUKBk6jwQb0b >>> > > > >> > > > >>> > Wi9QVDCVODH2mrSCHpEnxe2+KxdWDnrPb10/rikcY4KNRYsxPVUNvk+1P1fX7yvu >>> > > > >> > > > >>> > D2r5JJQxIuyuDZo9NQll540yJ7Rnp1TYgkCpIcdonleGC8yZwyCud8FHC6pld0jQ >>> > > > >> > > > >>> > l4RsLjJO0e2KF3MefrpkxRwfLNzUUuRrqmRNMx3Im9glmSHGZ8GhCz2UVB0TziZa >>> > > > >> > > > >>> > U2sXXjTntkR29HXciBY7J4NP/izH3KTSMBp4MLyuwe3oZGKHmTLir903VN9gaMxh >>> > > > >> > > > y08SO+AHfu0QE9N2cbKF6nCz1W+vBcjM7d6IHdNHWQKbwATyaiI= >>> > > > >> > > > =XFAH >>> > > > >> > > > -----END PGP SIGNATURE----- >>> > > > >> > > > >>> > > > >> > > > >>> > > > >> > >>> > > > >>> > >>> ======================================================================== >>> > > > >> > > > >>> > > > >> > > > CHANGELOG for 9.0.0-M2: >>> > > > >> > > > >>> > > > >> > > > ** Bug >>> > > > >> > > > >>> > > > >> > > > * [WICKET-6611] - Missing check for >>> > > > >> > > > IScopeAwareTextResourceProcessor when concatenating >>> resources >>> > > > >> > > > * [WICKET-6669] - CSS Resource Bundling throws >>> exception >>> > > when >>> > > > >> used >>> > > > >> > > > with CssUrlReplacer >>> > > > >> > > > * [WICKET-6671] - IAjaxLink should be serializable >>> > > > >> > > > >>> > > > >> > > > ** Improvement >>> > > > >> > > > >>> > > > >> > > > * [WICKET-6618] - Stateless pages and access to >>> > > unconfigured >>> > > > >> > > > components >>> > > > >> > > > * [WICKET-6656] - JSR 303 - @NotNull validation >>> problems >>> > > > >> > > > * [WICKET-6657] - change replaceAll() to replace() >>> when a >>> > > > >> regex is >>> > > > >> > > > not used >>> > > > >> > > > * [WICKET-6658] - Allow nested forms on non-<form> >>> tag >>> > > > >> > > > * [WICKET-6659] - commons-io:commons-io is used in >>> > multiple >>> > > > >> > > > versions at same time >>> > > > >> > > > * [WICKET-6662] - Remove legacy package >>> > > > >> > org.apache.wicket.util.time >>> > > > >> > > > from wicket-util >>> > > > >> > > > * [WICKET-6667] - Ajax JavaScript clean-up >>> > > > >> > > > * [WICKET-6668] - Sign out the existing session if a >>> sign >>> > > in >>> > > > >> > > > attempt has failed >>> > > > >> > > > >>> > > > >> > > > ** Task >>> > > > >> > > > >>> > > > >> > > > * [WICKET-6653] - Upgrade Velocity to 2.x >>> > > > >> > > > * [WICKET-6654] - Upgrade JQuery to 3.4.0 >>> > > > >> > > > * [WICKET-6661] - Upgrade jquery to 3.4.x >>> > > > >> > > > * [WICKET-6665] - Upgrade various dependencies >>> > > > >> > > > >>> > > > >> > > > >>> > > > >> > > >>> > > > >> > > -- >>> > > > >> > > WBR >>> > > > >> > > Maxim aka solomax >>> > > > >> > > >>> > > > >> > >>> > > > >> > >>> > > > >> > -- >>> > > > >> > Regards - Ernesto Reinaldo Barreiro >>> > > > >> > >>> > > > >> >>> > > > >> >>> > > > >> -- >>> > > > >> WBR >>> > > > >> Maxim aka solomax >>> > > > >> >>> > > > > >>> > > > > >>> > > > > -- >>> > > > > Regards - Ernesto Reinaldo Barreiro >>> > > > > >>> > > > >>> > > > >>> > > > -- >>> > > > Regards - Ernesto Reinaldo Barreiro >>> > > > >>> > > >>> > > >>> > > -- >>> > > Andrea Del Bene. >>> > > Apache Wicket committer. >>> > > >>> > >>> > >>> > -- >>> > Regards - Ernesto Reinaldo Barreiro >>> > >>> >>> >>> -- >>> Andrea Del Bene. >>> Apache Wicket committer. >>> >> >> >> -- >> Regards - Ernesto Reinaldo Barreiro >> > > > -- > Regards - Ernesto Reinaldo Barreiro > -- Regards - Ernesto Reinaldo Barreiro
