svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce
support: initial commit
URL: https://github.com/apache/wicket/pull/376#discussion_r303195128
##########
File path:
wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
##########
@@ -152,28 +155,48 @@ public static void writeJavaScriptUrl(final Response
response, final CharSequenc
public static void writeJavaScriptUrl(final Response response, final
CharSequence url,
Review comment:
Well, if we continue what we have done in the past, we have to add yet
another parameter "nonce". IMHO it's better to change it to receive a valueMap
instead, and let the caller fill it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
