svenmeier commented on a change in pull request #380: WICKET-6558 no lock after
detach
URL: https://github.com/apache/wicket/pull/380#discussion_r314032664
##########
File path: wicket-core/src/main/java/org/apache/wicket/Application.java
##########
@@ -1569,23 +1569,12 @@ public final RequestCycle createRequestCycle(final
Request request, final Respon
@Override
public void onDetach(final RequestCycle requestCycle)
{
- IPageManager pageManager;
-
- if (Session.exists())
- {
- pageManager =
Session.get().getPageManager();
- } else {
- pageManager = internalGetPageManager();
- }
- pageManager.detach();
+ internalGetPageManager().detach();
Review comment:
Sufficient to detach the page manager only. No need to detach the session
here, RequestCycle#onDetach() does it already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
