Hi Maxim,

we're still using jQuery, so the original code will do fine :)

Anything new should go into WICKET-6681.

Have fun
Sven


On 21.08.19 10:50, Maxim Solodovnik wrote:
The original code was with jQuery
It can be replaced with vanilla JS (
https://developer.mozilla.org/en-US/docs/Web/API/Element/classList) but
1) handling of multiple classes should be added
2) polyfill for IE11 should be added

shall I restore original code or replace it it with vanilla JS?

On Wed, 21 Aug 2019 at 15:28, Sven Meier <[email protected]> wrote:

Hi Maxim,

my bad, thanks for noticing. Yes, please restore it for WICKET-6667.

Many thanks
Sven


On 21.08.19 07:00, Maxim Solodovnik wrote:
Hello Sven,

while working on WICKET-6667 you have removed Wicket.DOM.toggleClass from
wicket-ajax-jquery
This method is being used
in org.apache.wicket.markup.html.form.AutoLabelResolver.AutoLabelMarker

Is it Ok if I'll restore this method?


Reply via email to