svenmeier commented on a change in pull request #382: WICKET-6688 add RFC and
replace eval with DOM eval
URL: https://github.com/apache/wicket/pull/382#discussion_r323792828
##########
File path:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
##########
@@ -956,7 +975,7 @@
try {
// do the evaluation in global
scope
- var f = window.eval(toExecute);
+ var f =
jQuery.globalEval(toExecute, {nonce: nonce});
Review comment:
globalEval() does not support a return value.
Actually this is a general problem (in #378 too): We cannot pass a parameter
into scripts evaluated in the header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
