martin-g commented on a change in pull request #383: Configurable
contentDisposition
URL: https://github.com/apache/wicket/pull/383#discussion_r326139180
##########
File path:
wicket-core/src/main/java/org/apache/wicket/markup/html/link/DownloadLink.java
##########
@@ -65,6 +65,14 @@
*/
private Duration cacheDuration;
+ /**
+ * Controls if the browser will save the file or display it inline.
+ * <p>
+ * The default is ATTACHMENT to maintain backward compatibility.
Review comment:
I am not sure there is a need for this in the javadoc. If we want to say
what is the default then maybe something like: `The default is ATTACHMENT
because this is what what <em>download</em> implies.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
