martin-g commented on a change in pull request #384: WICKET-6703 replace eval
with jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#discussion_r331761376
##########
File path:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
##########
@@ -823,15 +861,25 @@
return;
}
+ var nonce;
+ var meta = root.getElementsByTagName("meta")[0];
+ if (!isUndef(meta)) {
+ // var nonceEl =
meta.getElementsByTagName("wicket-nonce")[0];
+ // if (!isUndef(nonceEl)) {
+ // nonce =
Wicket.DOM.text(nonceEl);
+ // }
+ nonce =
Wicket.DOM.text(meta.getElementsByTagName("wicket-nonce")[0]);
Review comment:
From this line it seems that `meta` must always have a `wicket-nonce` child
in it.
AFAIU it `meta` is something more general. It can bring any kind of Ajax
response meta information. And `wicket-nonce` isn't something mandatory. At
least the server-side code doesn't say that `wicket-nonce` is mandatory when
`addMeta()` is used.
I think we should remove `meta` altogether and just add `nonce` as an
attribute of `<ajax-response>`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
