papegaaij commented on a change in pull request #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#discussion_r368974578
########## File path: wicket-core/src/test/java/org/apache/wicket/markup/html/basic/RedirectPage-expected1.html ########## @@ -0,0 +1,5 @@ +<html> Review comment: They were needed because the core stylesheet was added, but now they are not really needed anymore. These tests use the same markup as input and expected result. Is this something we would like to keep? The problem I see with that is that regenerating the expected result actually changes the input of the test. That's why I kept these files. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
