papegaaij commented on issue #401: WICKET-6726: remove inline styling and javascript from Form URL: https://github.com/apache/wicket/pull/401#issuecomment-577531197 @svenmeier I didn't remove the changes for WICKET-6527, only a very small part of it, namely the customizable classname. In WICKET-6527, the user requests that the styling of the hidden fields is customizable. As the inline styling is now gone and the fields are styled via a classname selector, this is now very easy. In fact, the user can replace the whole core stylesheet. I see no need to keep the classname customizable. Other customizable classnames serve a different need. Those classes are meant to be matched in user stylesheets. In those cases it is desirable to have them match other classnames in the application. This class had predefined styling, which must not conflict with user styling, hence the `wicket--` prefix. When the user wants to change the styling, he can match the wicket class with `div.wicket--hidden-fields` to make it more specific or replace the entire core stylesheet. Both solutions do not require changing the classname. I can introduce a second class, as suggested by @solomax, but I would like to see a valid use case first.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
