theigl opened a new pull request #411: Wicket 6751 Page synchronizer strategies
URL: https://github.com/apache/wicket/pull/411
 
 
   This PR adds support for providing a custom lock manager for page access 
synchronization. 
   
   Session-scoped locking only works in servlet container environments where 
the session is a global object but does not work with Spring Session where the 
session is (de)serialized to external storage on every request.
   
   For a detailed discussion of the subject see the [mailing 
list](http://mail-archives.apache.org/mod_mbox/wicket-users/202002.mbox/%3cCANtfzo5+YTBFzyP-U_dVjSrRu8xgv1qj4ozAWxDAbwVnF5=m...@mail.gmail.com%3e).
   
   The following changes were made:
   - Expose the currently package scoped methods for locking and waiting on a 
lock of `PageLock` so the class can be re-used in custom implementations
   - Encapsulate all logic related to locking to an `IPageLockManager` and move 
the current locking implementation to `DefaultPageLockManager`
   
   All changes are backwards-compatible from an API perspective. The only 
method that was moved is the `getTimeout(int pageId)` method on 
`PageAccessSynchronizer` that was public for some reason. I could add the 
method to the `IPageLockManager` interface and restore it as a delegate in 
`PageAccessSynchronizer` if wanted.
   
   See https://issues.apache.org/jira/projects/WICKET/issues/WICKET-6751

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to