Hello Martijn,
On Thu, 7 May 2020 at 19:02, Martijn Dashorst <martijn.dasho...@gmail.com>
wrote:
> IIRC Micromap was created for serialization and memory efficiency. Has that
> changed?
>
>From what I can see using "so to declaration" in JDK11
Map.of(key, value) returns
static final class Map1<K,V> extends AbstractImmutableMap<K,V> {
@Stable
private final K k0;
@Stable
private final V v0;
...............................
Which seems to be the same as we have now ....
>
> Martijn
>
> On Wed, May 6, 2020 at 2:18 PM Maxim Solodovnik <solomax...@gmail.com>
> wrote:
>
> > MicroMap can easily be replaced with Map.of(key, value)
> >
> > I can deprecate it for wicket9 in same PR, should I?
> >
> > On Wed, 6 May 2020 at 18:06, Maxim Solodovnik <solomax...@gmail.com>
> > wrote:
> >
> > > I would propose to remove it in Wicket9, but don't want to slow down
> the
> > > release :)
> > > Will create PR :)
> > >
> > > On Wed, 6 May 2020 at 17:56, Andrea Del Bene <an.delb...@gmail.com>
> > wrote:
> > >
> > >> +1 to replace it with ConcurrentHashMap.newKeySet()
> > >>
> > >> On 06/05/20 12:53, Martijn Dashorst wrote:
> > >> > I'd go further and deprecate it in wicket 8 as well... Since the
> > >> > replacement is in Java 8.
> > >> >
> > >> > I would be +1 on removing it from Wicket 9 final if it came to a
> vote.
> > >> It
> > >> > is not a core class in Wicket, it was not supposed to be used widely
> > >> > (mostly for our internal stuff), and would make it clear that when
> in
> > >> > doubt: use the JDK provided one.
> > >> >
> > >> > Martijn
> > >> >
> > >> >
> > >> > On Wed, May 6, 2020 at 12:36 PM Martin Grigorov <
> mgrigo...@apache.org
> > >
> > >> > wrote:
> > >> >
> > >> >> On Wed, May 6, 2020 at 1:20 PM Maxim Solodovnik <
> > solomax...@gmail.com>
> > >> >> wrote:
> > >> >>
> > >> >>> Hello All,
> > >> >>>
> > >> >>> ConcurrentHashSet can be safely removed from wicket codebase due
> to
> > >> >>> since Java8 it is possible to use ConcurrentHashMap.newKeySet()
> > >> >>>
> > >> >>> Can we @deprecate in in wicket9 and remove in Wicket10?
> > >> >>>
> > >> >> +1
> > >> >>
> > >> >>
> > >> >>> --
> > >> >>> Best regards,
> > >> >>> Maxim
> > >> >>>
> > >> >
> > >>
> > >
> > >
> > > --
> > > Best regards,
> > > Maxim
> > >
> >
> >
> > --
> > Best regards,
> > Maxim
> >
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
>
--
Best regards,
Maxim
