[GitHub] [wicket] martin-g commented on a change in pull request #440: WICKET-6807 Improve the check for the submitting component

[GitBox]

martin-g commented on a change in pull request #440:
URL: https://github.com/apache/wicket/pull/440#discussion_r466298812



##########
File path: 
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
##########
@@ -1711,7 +1725,7 @@ public final void writeHiddenFields()
        {
                // if it's a get, did put the parameters in the action 
attribute,
                // and have to write the url parameters as hidden fields
-               if (encodeUrlInHiddenFields())
+               if (METHOD_POST.equalsIgnoreCase(getMethod()))

Review comment:
       In that case let's always write them as hidden fields.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org