Hi Sven, On Wed, Sep 23, 2020 at 12:42 AM Sven Meier <s...@meiers.net> wrote:
> Hi all, > > anyone know why in AbstractUpgradeFilter we check > HttpServletResponse#isCommitted(): > > > https://github.com/apache/wicket/blob/78b7cf6612b167997f810bf89065f5755ae155a8/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/AbstractUpgradeFilter.java#L75 > > Apart from that this the code is identical to the super implementation. > > If we align the two - i.e. with #isCommitted() or without - > AbstractUpgradeFilter can just call the super implementation (after > checking a web socket upgrade). > > I don't really remember now. You can remove it and if the examples still work then it should be fine! > Have fun > Sven > >
