theigl opened a new pull request #454: URL: https://github.com/apache/wicket/pull/454
This PR reduces allocations in `PageParameters.mergeWith`. As a side-effect, it increases throughput 4x. **Master** Benchmark | Mode | Cnt | Score | Units ------------ | ------------- | ------------- | --: | ------------- ParameterBenchmarks.mergeWith | thrpt | 3 | **1746723,436** | ops/s ParameterBenchmarks.mergeWith:·gc.alloc.rate.norm | thrpt | 3 | 1600,190 | B/op ParameterBenchmarks.mergeWith:·gc.churn.G1_Eden_Space.norm | thrpt | 3 | 1602,183 | B/op **Branch** Benchmark | Mode | Cnt | Score | Units ------------ | ------------- | ------------- | --: | ------------- ParameterBenchmarks.mergeWith | thrpt | 3 | **7223753,855** | ops/s ParameterBenchmarks.mergeWith:·gc.alloc.rate.norm | thrpt | 3 | 320,046 | B/op ParameterBenchmarks.mergeWith:·gc.churn.G1_Eden_Space.norm | thrpt | 3 | 320,760 | B/op https://issues.apache.org/jira/browse/WICKET-6833 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org