theigl opened a new pull request #459: URL: https://github.com/apache/wicket/pull/459
This PR aligns caching of `isVisibleInHierarchy` with `isEnabledInHierarchy`. We are currently clearing the flag `RFLAG_VISIBLE_IN_HIERARCHY_SET` every time the visibility of a component changes, but we never use the flag. This PR adds `RFLAG_VISIBLE_IN_HIERARCHY_VALUE` to cache the result of the computation. I had to change the type of `requestFlags` from `short` to `int` because all available 16 bits are already used up. If my understanding of the JVM memory layout is correct, this should *not* increase memory usage because all object fields use at least one slot of 32 bits anyways (see https://stackoverflow.com/a/27123302/441266). I moved `RFLAG_HAS_REMOVALS` from `MarkupContainer` to `Component` so we do not accidentally assign the same bit to two different flags. See https://issues.apache.org/jira/projects/WICKET/issues/WICKET-6839 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
