I created a PR for this: https://github.com/apache/wicket/pull/507
I'll cherry-pick it onto 9.x when the PR is approved. Best, Thomas On Sun, Apr 3, 2022 at 10:42 PM Martin Grigorov <mgrigo...@apache.org> wrote: > Hi, > > I won't be able to help in the next few days. Just go ahead and improve it > the way you find good! > > Martin > > On Sun, Apr 3, 2022, 12:53 Thomas Heigl <tho...@umschalt.com> wrote: > > > I have to take back my +1. > > > > I found one more issue with WICKET-6965 while stress testing our staging > > environment: > > > > > > > https://issues.apache.org/jira/browse/WICKET-6965?focusedCommentId=17516488&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17516488 > > > > I think we should fix this before releasing 9.9.1. > > > > This websocket code seems to be quite hard to get right. > > > > Best, > > > > Thomas > > > > On Sat, Apr 2, 2022 at 11:34 AM Thomas Heigl <tho...@umschalt.com> > wrote: > > > > > +1 > > > > > > I think the changelog for WICKET-6963 should read "Revert: Use > singletons > > > for PanelMarkupSourcingStrategy", to make clear that it was reverted. > > > > > > Thomas > > > > > > > > > On Fri, Apr 1, 2022 at 10:21 PM Andrea Del Bene <an.delb...@gmail.com> > > > wrote: > > > > > >> This is a vote to release Apache Wicket 9.9.1 > > >> > > >> Please download the source distributions found in our staging area > > >> linked below. > > >> > > >> I have included the signatures for both the source archives. This vote > > >> lasts for 72 hours minimum. > > >> > > >> [ ] Yes, release Apache Wicket 9.9.1 > > >> [ ] No, don't release Apache Wicket 9.9.1, because ... > > >> > > >> Distributions, changelog, keys and signatures can be found at: > > >> > > >> https://dist.apache.org/repos/dist/dev/wicket/9.9.1 > > >> > > >> Staging repository: > > >> > > >> > > https://repository.apache.org/content/repositories/orgapachewicket-1172/ > > >> > > >> The binaries are available in the above link, as are a staging > > >> repository for Maven. Typically the vote is on the source, but should > > >> you find a problem with one of the binaries, please let me know, I can > > >> re-roll them some way or the other. > > >> > > >> Staging git repository data: > > >> > > >> Repository: g...@github.com:bitstorm/wicket.git > > >> Branch: build/wicket-9.9.1 > > >> Release tag: rel/wicket-9.9.1 > > >> > > >> > > >> > ======================================================================== > > >> > > >> CHANGELOG for 9.9.1: > > >> > > >> ** Bug > > >> > > >> * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore > > >> > > >> ** Improvement > > >> > > >> * [WICKET-6963] - Use singletons for PanelMarkupSourcingStrategy > > >> > > >> > > >
