I agree with Martin, especially with preserving package name and drop the copied class once commons-fileupload2 has been released.
On Tue, Jan 3, 2023 at 9:29 AM Martin Grigorov <mgrigo...@apache.org> wrote: > According to > > https://issues.apache.org/jira/browse/FILEUPLOAD-309?focusedCommentId=17652022&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17652022 > and > > https://jakarta.ee/specifications/platform/9/apidocs/jakarta/servlet/annotation/multipartconfig > it seems @MultipartConfig could be used only on Servlet, but not on a > Filter. > > I still believe copying the classes to wicket-util or > wicket-commons-fileupload is the best way to proceed. if we preserve the > package name then we can just drop them once commons-fileupload2 is > officially released. > > On Mon, Dec 19, 2022 at 5:41 PM Matt Pavlovich <mattr...@gmail.com> wrote: > > > IMO relying on the annotation to do configuration would be a show > stopper. > > > > > On Dec 17, 2022, at 7:01 AM, Martijn Dashorst < > > martijn.dasho...@gmail.com> wrote: > > > > > > Is commons-fileupload still necessary with the addition of multipart > > > support? > > > > > > https://www.baeldung.com/upload-file-servlet > > > > > > I assume we require servlet 3.0 at the minimum? > > > > > > Martijn > > > > > > > > > On Sat, Dec 17, 2022 at 1:56 AM Maxim Solodovnik <solomax...@gmail.com > > > > > wrote: > > > > > >> According to this: > > >> https://lists.apache.org/thread/22ro2qbstmrhrdq92g370kdsgf3fpfv2 > > >> > > >> There should be release soon :) > > >> > > >> > > >> from mobile (sorry for typos ;) > > >> > > >> > > >> On Sat, Dec 17, 2022, 01:38 Martin Grigorov <mgrigo...@apache.org> > > wrote: > > >> > > >>> Maybe copy the commons-file upload classes in a new Maven module? > > >>> > > >>> On Fri, Dec 16, 2022, 17:07 Thomas Heigl <tho...@umschalt.com> > wrote: > > >>> > > >>>> Hi, > > >>>> > > >>>> There doesn't seem to be any progress with commons-fileupload. > Should > > >> we > > >>>> start exploring other options? Or should we try to push some more on > > >> the > > >>>> JIRA? > > >>>> > > >>>> I'm still blocked by one other dependency (Apache Shiro) but they > are > > >>> close > > >>>> to releasing Jakarta artifacts. > > >>>> > > >>>> Best, > > >>>> > > >>>> Thomas > > >>>> > > >>>> > > >>>> On Tue, Apr 19, 2022 at 9:27 PM Martin Grigorov < > mgrigo...@apache.org > > > > > >>>> wrote: > > >>>> > > >>>>> On Tue, Apr 19, 2022 at 2:42 PM Thomas Heigl <tho...@umschalt.com> > > >>>> wrote: > > >>>>> > > >>>>>> OK I just saw that Martin already asked them to do a release in > > >>>>>> > > >>>> > > >> > > https://issues.apache.org/jira/projects/FILEUPLOAD/issues/FILEUPLOAD-309 > > >>>>> . > > >>>>>> > > >>>>> > > >>>>> 1 year ago ... > > >>>>> I see you JIRA voted for the issue. I think no one cares about the > > >>> number > > >>>>> of votes. Better add a comment! Comments go to the mailing list and > > >> the > > >>>>> maintainers are notified. > > >>>>> > > >>>>> > > >>>>> > > >>>>>> > > >>>>>> On Tue, Apr 19, 2022 at 1:35 PM Thomas Heigl <tho...@umschalt.com > > > > >>>>> wrote: > > >>>>>> > > >>>>>>> Hi, > > >>>>>>> > > >>>>>>> I started migrating our app to the new Jakarta APIs. Wicket is > > >> the > > >>>> only > > >>>>>>> dependency that doesn't yet have a pre-release. Is there anything > > >>>>>>> preventing us from releasing 10.0.0-M1? > > >>>>>>> > > >>>>>>> Is the SNAPSHOT dependency on commons-fileupload the only > > >> remaining > > >>>>>> issue? > > >>>>>>> If so, we should probably ask them to create a release candidate. > > >>>>>>> > > >>>>>>> Best, > > >>>>>>> > > >>>>>>> Thomas > > >>>>>>> > > >>>>>> > > >>>>> > > >>>> > > >>> > > >> > > > > > > > > > -- > > > Become a Wicket expert, learn from the best: http://wicketinaction.com > > > > > -- Andrea Del Bene. Apache Wicket committer.
