+1 tested with user guide examples. No problem if we have to restart the vote, but I see there's some work on other issues as well. At this point I'd rather go ahead with the current vote and release candidate. Please let me know if you prefer otherwise.
On Sun, Apr 16, 2023 at 4:52 PM Maxim Solodovnik <solomax...@gmail.com> wrote: > +1 > > Tested: > - signatures > - local build > - wicketstuff build > - main application build and run > > On Sun, 16 Apr 2023 at 21:36, Thomas Heigl <tho...@umschalt.com> wrote: > > > > Hi all, > > > > I didn't expect to, but I discovered one more *major* way to reduce > > allocations in ajax requests: > > > > - https://github.com/apache/wicket/pull/578 > > > > This avoids allocating some 50-100KB *per request* in our ajax heavy > > application. > > > > Then there are two other small improvements: > > > > - https://github.com/apache/wicket/pull/577 > > - https://github.com/apache/wicket/pull/579 > > > > I don't want to disrupt the vote once again and cause more work for > Andrea, > > so I'm OK with including these changes in 9.14.0, > > but I wanted to let you know in case someone else is interested in these > > improvements. > > > > Best, > > > > Thomas > > > > On Sat, Apr 15, 2023 at 3:08 PM Sven Meier <s...@meiers.net> wrote: > > > > > +1 please release 9.13.0 > > > > > > Thanks > > > Sven > > > > > > > > > On 14.04.23 21:13, Andrea Del Bene wrote: > > > > This is a vote to release Apache Wicket 9.13.0 > > > > > > > > > > > > Please download the source distributions found in our staging area > > > > linked below. > > > > > > > > I have included the signatures for both the source archives. This > vote > > > > lasts for 72 hours minimum. > > > > > > > > [ ] Yes, release Apache Wicket 9.13.0 > > > > [ ] No, don't release Apache Wicket 9.13.0, because ... > > > > > > > > Distributions, changelog, keys and signatures can be found at: > > > > > > > > https://dist.apache.org/repos/dist/dev/wicket/9.13.0 > > > > > > > > Staging repository: > > > > > > > > > https://repository.apache.org/content/repositories/orgapachewicket-1179 > > > > > > > > The binaries are available in the above link, as are a staging > > > > repository for Maven. Typically the vote is on the source, but should > > > > you find a problem with one of the binaries, please let me know, I > can > > > > re-roll them some way or the other. > > > > > > > > Staging git repository data: > > > > > > > > Repository: g...@github.com:bitstorm/wicket.git > > > > Branch: build/wicket-9.13.0 > > > > Release tag: rel/wicket-9.13.0 > > > > > > > > > > > > > ======================================================================== > > > > > > > > CHANGELOG for 9.13.0: > > > > > > > > ** Bug > > > > > > > > * [WICKET-7005] - ByteBuddy IllegalStateException: Cannot inject > > > > already loaded type > > > > * [WICKET-7022] - JavaScriptStripper fails to detect regular > > > > expression correctly > > > > * [WICKET-7028] - CSP header not rendered when using > > > > RedirectPolicy.NEVER_REDIRECT > > > > * [WICKET-7034] - WebSocket.Closed event not fired when error > > > > occurred > > > > * [WICKET-7037] - [Ajax Download] cookie used to track download > > > > complete misses the SameSite attribute > > > > * [WICKET-7044] - Images in the Wicket 9.x reference guide are > not > > > > displayed. > > > > > > > > ** Improvement > > > > > > > > * [WICKET-7011] - Improve usage of JUnit 5.x APIs > > > > * [WICKET-7014] - Use new API for forward compatibility with CDI > 4 > > > > * [WICKET-7016] - Support GCM-SIV for page store encryption > > > > * [WICKET-7017] - ListenerRequestHandler should not hide > > > > IndexOutOfBoundsException > > > > * [WICKET-7021] - Additional OSGi import fixes > > > > * [WICKET-7025] - Package private methods should be proxied by > > > > ByteBuddy > > > > * [WICKET-7031] - Update to JQuery 3.6.4 > > > > * [WICKET-7032] - Update the JS tests to use latest version of > > > > QUnit (2.x) > > > > * [WICKET-7035] - fileCountMax should be added to control the > > > > amount of files being uploaded > > > > * [WICKET-7041] - Reduce allocations when rendering component > headers > > > > * [WICKET-7042] - Improve sizing of StringResponse when writing > > > > scripts in PartialPageResponse > > > > > > > > > > > > > > > > > > > -- > Best regards, > Maxim > -- Andrea Del Bene. Apache Wicket committer.
