Hi Maxim- I understand that preference— this is a build-vs-buy decision. My point is that a file upload handler makes sense for Wicket to host itself, considering it is a small set of functions and relates to storage management needed by Wicket apps. Also, Wicket is more active in development and adopting JDK and Jakarta EE than the commons-file upload project. I suspect we’ll be right back here as the Servlet spec is evolving in Jakarta EE. -Matt
> On Jun 16, 2023, at 2:32 AM, Maxim Solodovnik <solomax...@gmail.com> wrote: > > On Thu, 15 Jun 2023 at 00:40, Matt Pavlovich <mattr...@gmail.com> wrote: >> >> Why add it back? The feature is just a couple of classes. >> commons-fileupload2 can continue to serve as a reference implementation to >> draw from. >> >> These backside dependencies create headaches when building web applications >> with Wicket that are platforms that allow end-users to provide their own >> plugins or extensions that may use the same or similarly versioned >> dependencies. > > IMO it's bad practice to copy/paste other libraries, > having fileupload2 as dependency we have all fixes and additional testing :) > > BTW the build of my branch seems to be green, only minor issues with > Automatic-Module-Name remain unresolved :) > >> >> Thanks, >> Matt >> >>> On Jun 14, 2023, at 11:48 AM, Maxim Solodovnik <solomax...@gmail.com> wrote: >>> >>> Hello All, >>> >>> I've start working on migration back to commons-fileupload 2.0.0-M1 >>> (the branch is here: [1] :))) >>> >>> Latest version of commons-fileupload2 has couple of issues >>> 1) missing `Automatic-Module-Name` >>> 2) FileItemHeadersImpl is not public anymore >>> (discussion is here: [2]) >>> >>> I'm going to have vacation in a couple of days (will be offline almost >>> all the time :) >>> >>> Can someone take a look at [2] ? >>> So we have all required features at 2.0.0-M1 release? >>> >>> Thanks in advance :) >>> >>> [1] https://github.com/apache/wicket/blob/commons-fileupload2-back >>> [2] https://lists.apache.org/thread/gjglf0c1xzdrhm143swfcq0xpg5ofrqk >>> >>> -- >>> Best regards, >>> Maxim >> > > > -- > Best regards, > Maxim
