Hi Johannes,
On Thu, Jul 13, 2023 at 3:23 PM Johannes Renoth <johan...@renoth.dev> wrote: > Hi all, > > First of all: Thanks for providing continued support and even further > development for Wicket. > > Now to my questions: > > Since Wicketstuff only has TinyMCE until version 4 but this version has > some serious vulnerabilites https://security.snyk.io/package/npm/tinymce > and the version used in wicketstuff is really old (4.3.4) i have begun > to implement a Wicket-Integration of trumbowyg > https://alex-d.github.io/Trumbowyg/ and > https://github.com/renoth/wicket-trumbowyg > > I already have a maven nexus account to release artifacts on maven > central, but before i do this i have some questions > > Do you plan to update Tinymce to latest version? > WicketStuff hosts libraries maintained by the community. That is, someone like you needed a WYSIWYG Wicket component and used TinyMCE. Coded it, polished it and contributed it to WicketStuff so other user could use and improve it. If you think TinyMCE 6.x is a nice widget (better than Trumbowyg ?!) then you can update the WicketStuff component from 4.x to 6.x and send a PR! > > Is there an alternative already implemented? > There are! E.g. https://github.com/l0rdn1kk0n/wicket-bootstrap/tree/wicket-9.x/bootstrap-extensions/src/main/java/de/agilecoders/wicket/extensions/markup/html/bootstrap/editor provides such integration with https://summernote.org/ > Would you be interested in integrating the code into wicketstuff? If > yes, would you do a code review? > We could add you as a contributor to WicketStuff to make it easier for you to maintain it. But using Pull Request with reviews is usually recommended for better qualitiy! > > The plugin structure of trumbowyg is somewhat finegrained and there is > some serious loading of lots of js and css files necessary at the moment > see > > https://github.com/renoth/wicket-trumbowyg/blob/master/src/main/java/dev/renoth/trumbowyg/TrumboWygBehavior.java#L70-L107, > > maybe someone has an idea how to improve it to only need one request per > JS and CSS in total > > Other than that i works great with a quickstart. > > Thank you for your time, > > Johannes Renoth > > > >
