Hi,
in parent pom.xml you are referencing
<jakarta.servlet-api.version>6.0.0</jakarta.servlet-api.version>
but here you state that Servlet 5+ is required:
https://cwiki.apache.org/confluence/display/WICKET/Migration+to+Wicket+10.0#MigrationtoWicket10.0-Wicket10requiresServlet5+
I've been bitten by this today when users couldn't sign in the app as
CookieUtils.initializeCookie uses 6.0.0 api, start of the stacktrace:
java.lang.NoSuchMethodError: 'void
jakarta.servlet.http.Cookie.setAttribute(java.lang.String,
java.lang.String)'
at
org.apache.wicket.util.cookies.CookieUtils.initializeCookie(CookieUtils.java:341)
at
org.apache.wicket.util.cookies.CookieUtils.save(CookieUtils.java:294)
at
org.apache.wicket.util.cookies.CookieUtils.save(CookieUtils.java:168)
at
org.apache.wicket.authentication.strategy.DefaultAuthenticationStrategy.save(DefaultAuthenticationStrategy.java:148)
Cookie.setAttribute is not present in 5.0.0 jservlet-api.
Vit
On 28. 11. 23 17:05, Martin Grigorov wrote:
Hi,
On Tue, 28 Nov 2023 at 16:55, Andrea Del Bene <an.delb...@gmail.com> wrote:
Just a brief mail to summarize the job status for Wicket 10. AFAIK there
are some few minor activity that should be done before releasing the new
main release, for example reworking the ApacheLicenseHeaderTest to make it
work with JPMS.
There is no such issue. The test works fine today!
Some people suggested to replace it with maven-rat-plugin but this is just
an idea to replace one solution with another.
However I think we might start to contact press team to start working on
the official release statement which (by experience) is a non trivial task
that might take some time before coming to final draft.
Do you think the time is right to plan this activity or do you prefer to
wait until the open activities are completed? Do you thing an M3 version is
needed?
I’ll let others share their experiences with M2.
I’d just ask for reviews of the currently open PRs.
--
Andrea Del Bene.
Apache Wicket committer.