Op do 7 dec 2023 om 08:58 schreef Emond Papegaaij <emond.papega...@gmail.com >:
> Op do 7 dec 2023 om 02:35 schreef Maxim Solodovnik <solomax...@gmail.com>: > >> File timestamps might be set to `project.build.outputTimestamp` by Maven >> This enables "reproducible builds" >> https://maven.apache.org/guides/mini/guide-reproducible-builds.html >> >> I believe Maven `project.build.outputTimestamp` property should be set >> in the pom.xml by release manager during release >> should be easy to check :) (sorry, I don't have time to check it myself >> :(((( ) >> > > I think just adding the property set to the current date should be enough. > The maven-release-plugin will take care of updating the property during the > release as you can see here: > https://github.com/apache/maven/commit/3fc399318edef0d5ba593723a24fff64291d6f9b#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R176 > I've just opened a PR with this change ( https://github.com/apache/wicket/pull/758). I don't think this change will be problematic, but as it only really influences the release builds, it's hard to test its effect without doing an actual release. Best regards, Emond
