Hi, currently the code to get a specific PackageResource needs to decide if
its style will come from the PackageResourceReference, from the session, or
from the URL. Taking a look at the PackageResourceReference#getCurrentStyle
[1]:
private String getCurrentStyle(UrlAttributes attributes) {
String currentStyle = getCurrentStyle();
return currentStyle != null
? currentStyle
: attributes != null
? attributes.getStyle()
: null;
}
It seems that the style in the URL is the last one to get used, so I wonder
if the expectation in the test case [2] is right (I think it is) and if
it's ok to change the PackageResourceReference keeping the test expectation
during the work to remove the duplicated resource URL attributes decoding
logic in the ticket WICKET-7129 [3].
1 -
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResourceReference.java#L221
2 -
https://github.com/apache/wicket/blob/a5e43aeed041e0366d01a1a35aa48ed1bf62a581/wicket-core-tests/src/test/java/org/apache/wicket/core/request/resource/PackageResourceReferenceTest.java#L442
3- https://issues.apache.org/jira/browse/WICKET-7129
Pedro Santos
