Hi, I prefer to take more time on the ticket. Please go ahead. Cheers,
Pedro Santos On Thu, Dec 12, 2024 at 5:46 AM Andrea Del Bene <an.delb...@gmail.com> wrote: > Thank you Pedro. Should I wait for you to solve WICKET-7107 before starting > a new release vote for the 10.3.0 or do you prefer to take more time for > it? > > On Wed, Dec 11, 2024 at 5:56 PM Pedro Santos <pedros...@gmail.com> wrote: > > > Thank you, Andrea > > > > I reverted the commit and tested the version in the master on our main > app > > and wicket examples, and all looks good. > > > > Pedro Santos > > > > > > On Wed, Dec 11, 2024 at 7:15 AM Andrea Del Bene <an.delb...@gmail.com> > > wrote: > > > > > No problem, I will start another release round when it's ok > > > > > > On Tue, Dec 10, 2024 at 6:39 PM Pedro Santos <pedros...@gmail.com> > > wrote: > > > > > > > Hi, I'm getting: > > > > > > > > ERROR org.apache.wicket.csp.ReportCSPViolationMapper > > > > > > > > Errors testing wicket-example pages, and the CSS is failing to load > > when > > > > visiting a page (e.g. echo). I was able to pinpoint the error to the > > > > changes in the ticket WICKET-7107 [1]. I will revert the commit and > > > reopen > > > > it to work on this problem. > > > > > > > > 1 - https://issues.apache.org/jira/browse/WICKET-7107 > > > > > > > > Pedro Santos > > > > > > > > > > > > On Tue, Dec 10, 2024 at 4:42 AM Maxim Solodovnik < > solomax...@gmail.com > > > > > > > wrote: > > > > > > > > > +1 > > > > > > > > > > Tested: > > > > > - signatures > > > > > - build from sources > > > > > - wicketstuff build > > > > > - our main app > > > > > > > > > > On Tue, 10 Dec 2024 at 14:37, Viliam Repan > > > > > <viliam.re...@evolveum.com.invalid> wrote: > > > > > > > > > > > > +1 > > > > > > > > > > > > Best regards, > > > > > > > > > > > > > > > > > > viliam > > > > > > > > > > > > > On 9 Dec 2024, at 23:37, Andrea Del Bene <an.delb...@gmail.com > > > > > > wrote: > > > > > > > > > > > > > > This is a vote to release Apache Wicket 10.3.0 > > > > > > > > > > > > > > Please download the source distributions found in our staging > > area > > > > > > > linked below. > > > > > > > > > > > > > > I have included the signatures for both the source archives. > This > > > > vote > > > > > > > lasts for 72 hours minimum. > > > > > > > > > > > > > > [ ] Yes, release Apache Wicket 10.3.0 > > > > > > > [ ] No, don't release Apache Wicket 10.3.0, because ... > > > > > > > > > > > > > > Distributions, changelog, keys and signatures can be found at: > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/wicket/10.3.0 > > > > > > > > > > > > > > Staging repository: > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachewicket-1208 > > > > > > > > > > > > > > The binaries are available in the above link, as are a staging > > > > > > > repository for Maven. Typically the vote is on the source, but > > > should > > > > > > > you find a problem with one of the binaries, please let me > know, > > I > > > > can > > > > > > > re-roll them some way or the other. > > > > > > > > > > > > > > Staging git repository data: > > > > > > > > > > > > > > Repository: g...@github.com:bitstorm/wicket.git > > > > > > > Branch: build/wicket-10.3.0 > > > > > > > Release tag: rel/wicket-10.3.0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ======================================================================== > > > > > > > > > > > > > > CHANGELOG for 10.3.0: > > > > > > > > > > > > > > ** Bug > > > > > > > > > > > > > > * [WICKET-3899] - IFormVisitorParticipant don't get tested > > when > > > > > validating form validators dependent components > > > > > > > * [WICKET-7024] - Wrong static resource urls when their > > > > generation > > > > > is triggered by <wicket:link> > > > > > > > * [WICKET-7107] - CSP Header not rendered when using > > > > > RedirectPolicy.AUTO_REDIRECT > > > > > > > * [WICKET-7124] - The quickstart archetype fails to build > > > > > > > * [WICKET-7125] - To use cdi-unit CreationalContext to > inject > > > > > beans in Wicket components during tests > > > > > > > > > > > > > > ** Improvement > > > > > > > > > > > > > > * [WICKET-7123] - Form.setDefaultButton() supports only one > > > > button > > > > > per form hierarchy > > > > > > > * [WICKET-7131] - Improve accessibility and screen reader > > > support > > > > > for auto-complete component > > > > > > > * [WICKET-7133] - Ability move focus back to the > autocomplete > > > > > field when selecting an item using the Tab key > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Best regards, > > > > > Maxim > > > > > > > > > > > > > > > > > > -- > > > Andrea Del Bene. > > > Apache Wicket committer. > > > > > > > > -- > Andrea Del Bene. > Apache Wicket committer. >
