dashorst opened a new issue, #1844:
URL: https://github.com/apache/wicket/issues/1844

   The reference guide looks like any other Asciidoctor document rather than 
part of wicket.apache.org, and its code samples have no syntax highlighting at 
all.
   
   - **No highlighting.** The pom passes 
`<sourceHighlighter>coderay</sourceHighlighter>`, which is not a parameter of 
asciidoctor-maven-plugin 2.x. The plugin ignores it (it logs `Parameter 
'sourceHighlighter' is unknown`), so all of the guide's 500+ listings, most of 
them Java and HTML, render as plain text.
   - **A forked stylesheet.** `css/style.css` is a 2017 copy of the minified 
default Asciidoctor stylesheet, changed only to use a sans-serif body font 
(WICKET-6372). Any restyle means editing 400 lines of minified CSS, and the 
copy no longer follows Asciidoctor upgrades.
   - **External requests.** The page loads Font Awesome from cdnjs for the 
admonition icons.
   - **Navigation.** The table of contents lists every section of a very long 
single page, with no indication of where you are.
   
   Proposal: keep the default stylesheet and put a small override on top 
through docinfo, in the design of wicket.apache.org (its tokens, its 
self-hosted Alegreya and JetBrains Mono fonts, its Rouge colours). Switch to 
Rouge through the `source-highlighter` attribute, add a masthead linking back 
to the site and Javadoc, let the table of contents follow the section being 
read, give listings a language label and a copy button, restyle the admonitions 
as asides, and add a dark mode. The PDF output stays as it is.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to