dashorst opened a new issue, #1868: URL: https://github.com/apache/wicket/issues/1868
Write down what a review of a Wicket pull request checks, so human and agent reviewers apply the same checks to every change, and make the checklist part of the workflow. `AGENTS.md` describes how to write a change: format, commits, build, API compatibility, Javadoc, comments, security. Nothing describes what to check when reviewing one. The checks this issue should cover: - **License compliance**: ASF headers, the licenses of new dependencies under the ASF third-party policy, and `LICENSE`, `LICENSE-binary`, `NOTICE` and `licenses/` for third-party code or assets copied into the tree. - **OSGi and JPMS**: the bundle manifest and `module-info.java` stay consistent with the pom when packages or dependencies change. - **Performance**: a change to a hot path keeps its complexity and memory footprint, or shows with a benchmark that the cost is worth it. During the dependency cleanup for #1862, a first draft replaced `LinkedMap` in `MarkupContainer` and made single child removal O(n). - **Accessibility**: markup, components and JavaScript that render UI keep meeting WCAG. - **Documentation**: changes users notice update the migration guide, user guide or Javadoc in the same pull request. - **Serialization**: changes to the serialized form of components and models, which affect stored pages and session size. - **Tests**: new test classes end in `Test`, or Surefire never runs them. Proposal: a `REVIEW.md` in the repository root with these checks, referenced from `AGENTS.md` so agents writing a change check it against the same list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
