+1 Reformat all code. We should add these commits to .git-blame-ignore-revs
Op zo 8 nov 2026 om 14:56 schreef Maxim Solodovnik <[email protected]>: > > On Sun, 8 Nov 2026 at 19:08, Martijn Dashorst > <[email protected]> wrote: > > > > Of course, reading before sending is a skill this human intelligence > > lacks... > > :) > > > > > Issue: > > - https://github.com/apache/wicket/issues/1867 > > > > PRs: > > - #1871 for master: https://github.com/apache/wicket/pull/1871 > > - #1872 for wicket-11.x: https://github.com/apache/wicket/pull/1872 > > - #1873 for wicket-10.x: https://github.com/apache/wicket/pull/1873 > > +1 > We should have all maintained branches aligned :) > > > > > Martijn > > > > On Sun, Nov 8, 2026 at 12:59 PM Martijn Dashorst > > <[email protected]> wrote: > > > > > > All, > > > > > > We probably should have adhered to this long ago, but due to years of > > > development we now have a diverging code base regarding code > > > formatting. > > > While this is not a cardinal sin, it is rather easy to fix, and to > > > prevent e.g. windows line endings to rewrite the whole file. > > > > > > At dayjob we use the spotless maven plugin to reformat and check the > > > formatting of our code bases. This works wonderfully, and allows > > > agents to also write consistent code. > > > > > > I've asked my agent to distill the "Wicket Code Formatting Rules" from > > > the source code and make it a spotless profile. I also asked it to > > > export it into eclipse and intellij formatter profiles. > > > > > > This is marked under this ticket: > > > > > > I have prepared 3 PRs: > > > - master > > > - wicket-11.x > > > - wicket 10.x > > > > > > This will require existing PRs to be reformatted prior to merge, but I > > > don't think that is a big issue. > > > > > > WDYT? Should we adopt this: > > > > > > - reformat all active code bases > > > - implement a CI gate for code formatting issues > > > > > > Martijn > > > > -- > Best regards, > Maxim
