hosea opened a new issue, #1881: URL: https://github.com/apache/wicket/issues/1881
There are two implementations for the same task: defining a value for the "type"-Attribute of a script-Tag: 1. org.apache.wicket.markup.head.JavaScriptReferenceType for AbstractJavaScriptReferenceHeaderItem (and subclasses) 2. org.apache.wicket.markup.head.JavaScriptContentType and org.apache.wicket.markup.head.JavaScriptBrowserProcessedContentType for JavascriptContentHeaderItem Observation: all subclasses of JavascriptHeaderItems have (their own) solution to define a value for the "type"-Attribute Conclusion: define the value for the "type"-Attribute in JavascriptHeaderItem - similar to the "id"-Attribute. I personally like the style of the 2nd way with interface org.apache.wicket.markup.head.JavaScriptContentType but prefer to implement Constants directly in the Interface-Class. I prepared a PR for this based on the Wicket 10 - Branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
