dashorst opened a new issue, #1891: URL: https://github.com/apache/wicket/issues/1891
Two problems in the restyled reference guide (#1845), both in `css/wicket.css`, found while checking the accessibility chapter (#1847) in the new design. ## Table header rows are unreadable in dark mode `asciidoctor.css` gives `table thead`, `table tfoot` and `tbody tr th` the background `#f7f8f7`. `wicket.css` overrides the text colour of the header cells for dark mode but not this background, so in dark mode the header row is light grey text, `rgb(164, 184, 176)`, on an almost white background: a contrast of about 2:1, where WCAG 2.2 success criterion 1.4.3 asks for 4.5:1. It shows on the two tables with a header row on master plus #1847: the table in "Working with AJAX" (chapter 19) and the WCAG criteria table in "Accessibility" (chapter 25, from #1847). A dark-mode rule for `table thead`, `table tfoot` and `tbody tr th` that uses the page's own surface colour would fix both. ## The page scrolls sideways at phone width Below 768px, `#toc.toc2` gets `margin: 0 -36px` (`wicket.css`, the `max-width: 767px` block). The table of contents then reaches from -18px to 393px on a 375px wide viewport, and the whole page scrolls 18px sideways (success criterion 1.4.10 asks for no scrolling in two directions at 320 CSS pixels). A negative margin that matches the padding of its container would keep the full-bleed look without the overflow. Both were seen in `target/generated-docs/single.html` built with `mvn -pl wicket-user-guide -Pguide generate-resources` on master at 745ae018ec, in a 375 × 667 viewport and with `prefers-color-scheme: dark`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
