dashorst opened a new pull request, #27:
URL: https://github.com/apache/wicket-site/pull/27

   Without its webfonts the site fell back to Georgia for Alegreya and, for 
Alegreya Sans, to the serif Alegreya and then a generic sans-serif. The stacks 
now fall back to faces of the same kind that the systems ship. This matters 
more now that the reference guide takes its fonts from webjars at build time 
(for apache/wicket#1846): a guide built without them falls back to these 
stacks, and the guide copies them from here.
   
   | Role | After the webfont |
   |---|---|
   | Serif and small caps (Alegreya, Alegreya SC) | Iowan Old Style, Palatino 
Linotype, Palatino, URW Palladio L, P052, Georgia, serif |
   | Sans (Alegreya Sans) | Seravek, Gill Sans Nova, Ubuntu, Calibri, 
sans-serif |
   | Mono (JetBrains Mono) | ui-monospace, SFMono-Regular, Menlo, Cascadia 
Code, Consolas, monospace |
   
   ## For review
   
   - **Core:** the four font tokens in `_sass/ribbon/_base.scss`, and 
`DESIGN.md`: the front matter, the Typography section and a Fallbacks paragraph.
   - **Mechanical:** the second commit rebuilds `content/`. Apart from 
`css/style.css` and its source map it only changes the `?v=` cache-busters and 
the feed's `<updated>` date.
   - **No size-adjust:** the metrics of Iowan Old Style, Palatino Linotype, 
Seravek, Gill Sans Nova and Calibri are not at hand, so the fallbacks are not 
metric-matched. Georgia sets about 9% wider than Alegreya and has a 6% taller 
x-height (capsize metrics).
   - **Small caps:** labels lose them in the fallback.
   
   ## Tested
   
   Jekyll build: the built `style.css` differs from the previous one only in 
the four stacks. The webfonts still come first in every stack, so the site 
looks the same while they load. The fallback rendering itself was not checked 
in a browser.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to