dashorst opened a new issue, #1929:
URL: https://github.com/apache/wicket/issues/1929

   The entries in the reference guide's table of contents have no space between 
the section number and the title in their text. Screen readers announce them 
as, for example, "3.Why should I learn Wicket?" and "13.4.Pageable repeaters".
   
   The cause is `followSections()` in 
`wicket-user-guide/src/main/asciidoc/js/guide.js`. It splits each TOC link into 
a `span.toc-num` holding the number and a text node holding the title, and 
drops the whitespace in between. The visual gap comes from `margin-right` on 
`.toc-num` in `wicket.css`, so on screen it looks fine, but the link's text 
content and accessible name have no space. This was introduced in #1845.
   
   The same text ends up in other names built from the link. In #1904 the 
disclosure buttons are labelled "Sections for 3.Why should I learn Wicket?".
   
   Fix: keep the space in the text when the link is split up. One way is to 
append `' ' + match[2]` instead of `match[2]` and drop the `margin-right` from 
`.toc-num`. Then check that the TOC still looks the same and that the 
accessible names read "3. Why should I learn Wicket?".
   
   This touches the same lines in `guide.js` as #1904, so it should wait until 
#1904 is merged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to