dashorst opened a new issue, #1938:
URL: https://github.com/apache/wicket/issues/1938

   From 768 px up, the reference guide scrolls sideways by the width of the 
table of contents. At 1280 px the page is 1584 px wide, 304 px wider than the 
window, and the whole extra width belongs to the footer.
   
   ## Cause
   
   The Asciidoctor default stylesheet gives `#header, #content, #footnotes, 
#footer` a `width: 100%`. `wicket.css` then shifts the four of them right with 
`margin-left: var(--toc-w)` (line 209) to make room for the table of contents. 
`#header`, `#content` and `#footnotes` keep a `max-width` and get 
`margin-right: auto`, so they still fit. `#footer` has `max-width: none` (line 
388), so it stays as wide as the window, starts `--toc-w` further right, and 
sticks out past the right edge.
   
   Seen in Chromium on a build of `wicket-user-guide` with `-Pguide`. It is on 
`master` since #1845, and on `wicket-11.x` since #1937, which brought the same 
stylesheet over unchanged.
   
   ## Not covered by #1903
   
   #1903 fixes the 18 px sideways scroll at phone width (#1891). That is a 
different overflow. #1903 does not touch `#footer`, and below 768 px the footer 
has no margin, so it does not overflow there.
   
   ## Fix
   
   Let the footer take only the width the table of contents leaves, for example 
`width: auto` on `body.toc2 > #footer` in the same media query. It can then 
still run to the right edge on the cloth background. The fix goes on `master` 
first and is cherry-picked to `wicket-11.x`.
   
   ## Done when
   
   - At 1280 px, `document.documentElement.scrollWidth` equals the window width.
   - The footer's cloth background still runs from the edge of the table of 
contents to the right edge of the window.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to