reiern70 opened a new issue, #1944:
URL: https://github.com/apache/wicket/issues/1944

   **Affects:** 11.0.0 and current master
   **Component:** wicket-extensions, `PageVeilBehavior`, `wicket-veil.js`
   
   ## What happens
   
   A page with `PageVeilBehavior`, a field that updates the server on `change`, 
and a button:
   
   ```java
   add(new PageVeilBehavior());
   field.add(new AjaxFormComponentUpdatingBehavior("change") {
       @Override
       protected void onUpdate(AjaxRequestTarget target) {
           Thread.sleep(1000); // a round trip longer than a click
       }
   });
   form.add(new AjaxButton("save") {
       @Override
       protected void onSubmit(AjaxRequestTarget target) {
           runs.incrementAndGet();
       }
   });
   ```
   
   Type something in the field, then click Save once with the mouse. The 
field's request is sent, but Save never runs: `runs` stays 0. Without 
`PageVeilBehavior`, Save runs once.
   
   Checked with a real mouse click through WebDriver in Chrome 155 and Firefox 
124.
   
   ## Cause
   
   1. The press on Save moves the focus, so the field fires `change` within the 
`mousedown`.
   2. The channel is free, so Wicket sends the request at once, and the veil is 
appended to `body` in `/ajax/call/beforeSend`, before the mouse comes up.
   3. The `mouseup` lands on the veil. The browser fires `click` on the nearest 
common ancestor of the `mousedown` and `mouseup` targets, here `body`, not on 
the button.
   
   The user sees the field saved and Save doing nothing. This happens whenever 
the field's round trip lasts longer than the press, and every form with an 
updating field is open to it.
   
   ## Fix proposed
   
   In `wicket-veil.js`:
   
   1. Remember the element of a `pointerdown` made while no veil covered it.
   2. If the matching `pointerup` lands on a veil, call `click()` on that 
element once the veil is lowered.
   3. Skip the replay if the element is no longer in the page, is hidden or 
disabled, or if a new press started meanwhile. If the answer replaced the 
element, replay on the element now carrying the same id.
   
   ## Workaround
   
   None short of patching the veil's script: the click is never fired, so the 
application has nothing to listen to.
   
   Related: #1631, #1942. Found while working on reiern70/advanced-widgets#141.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to