[
https://issues.apache.org/jira/browse/WSS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088718#comment-13088718
]
Daniel Kulp commented on WSS-312:
---------------------------------
I have to say that I disagree with this patch. This is really a "log and
rethrow" anti-pattern which, to me, is a bad idea. Let the caller catch the
exception and determine if the right thing to do is log the exception at
whatever log level is appropriate or handle it or whatever.
> Improve logging levels
> ----------------------
>
> Key: WSS-312
> URL: https://issues.apache.org/jira/browse/WSS-312
> Project: WSS4J
> Issue Type: Improvement
> Components: WSS4J Core
> Affects Versions: 1.6.2
> Reporter: Anubhav Sharma
> Assignee: Colm O hEigeartaigh
> Priority: Minor
> Fix For: 1.6.3
>
> Attachments: 0001-Improved-logging-levels.patch
>
>
> In the source code at most of the places where exception is thrown, exception
> is logged at debug level. Ideally it should be at warn or error level. This
> would improve overall logging in the library.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
