[
https://issues.apache.org/jira/browse/AXIOM-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276239#comment-13276239
]
Hudson commented on AXIOM-422:
------------------------------
Integrated in ws-axiom-trunk #964 (See
[https://builds.apache.org/job/ws-axiom-trunk/964/])
AXIOM-422: Ensure that SOAPElement#checkParent is invoked consistently.
(Revision 1338888)
Result = SUCCESS
veithen :
Files :
* /webservices/commons/trunk/modules/axiom
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ChildNode.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPElement.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPHeaderBlockImpl.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMElementImpl.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPHeaderBlockImpl.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestSuiteBuilder.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/fault/TestWrongParent1.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/fault/TestWrongParent2.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/fault/TestWrongParent3.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/headerblock/TestWrongParent1.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/headerblock/TestWrongParent2.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/headerblock/TestWrongParent3.java
> SOAPElement#checkParent not invoked consistently
> ------------------------------------------------
>
> Key: AXIOM-422
> URL: https://issues.apache.org/jira/browse/AXIOM-422
> Project: Axiom
> Issue Type: Bug
> Components: DOOM, LLOM
> Affects Versions: 1.2.13
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Priority: Minor
> Fix For: 1.2.14
>
>
> SOAPElement (both the LLOM and DOOM variant) defines a mechanism that
> validates that each type of SOAP element can only be added in the right place
> (e.g. that a SOAPHeader can only be added as a child of a SOAPEnvelope). This
> is implemented by overriding the setParent method:
> /** This has to be implemented by all the derived classes to check for
> the correct parent. */
> protected abstract void checkParent(OMElement parent) throws
> SOAPProcessingException;
> public void setParent(OMContainer element) {
> super.setParent(element);
> if (element instanceof OMElement) {
> checkParent((OMElement) element);
> }
> }
> However, this code is not invoked in all cases:
> * In LLOM, it is invoked by insertSiblingAfter and insertSiblingBefore, but
> not by addChild.
> * In DOOM, it is never invoked because the setParent method is not overridden
> (although the checkParent methods are defined).
> * It is not invoked for SOAPHeaderBlock because SOAPHeaderBlock extends
> OMSourcedElement and the setParent method is not overridden (although the
> checkParent methods are present).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
