[
https://issues.apache.org/jira/browse/AXIOM-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552217#comment-13552217
]
Hudson commented on AXIOM-116:
------------------------------
Integrated in ws-axiom-trunk #1358 (See
[https://builds.apache.org/job/ws-axiom-trunk/1358/])
Dead code elimination:
If OMNavigator#isNavigable() and OMNavigator#isCompleted() both return false,
then this means that the next node has not been built. This implies that there
must be a builder and that the builder is not complete, i.e. builder != null
and StAXOMBuilder#isCompleted() returns false.
Note that this code was added in AXIOM-116, but no unit test was ever produced
to show the purpose of this code. (Revision 1432625)
Result = SUCCESS
veithen :
Files :
*
/webservices/commons/trunk/modules/axiom/modules/axiom-common-impl/src/main/java/org/apache/axiom/om/impl/common/SwitchingWrapper.java
> Don't call builder.next() if builder is completed
> -------------------------------------------------
>
> Key: AXIOM-116
> URL: https://issues.apache.org/jira/browse/AXIOM-116
> Project: Axiom
> Issue Type: Bug
> Reporter: Rich Scheuerle
> Assignee: Rich Scheuerle
>
> Problem:
> Builder.next() is invoked with a builder that is completed. I received the
> following stack trace from Huiran Wang.
> Caused by: org.apache.axiom.om.OMException
> at
> org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:159)
> at
> org.apache.axiom.om.impl.llom.OMElementImpl.buildNext(OMElementImpl.java:628)
> at
> org.apache.axiom.om.impl.llom.OMNodeImpl.getNextOMSibling(OMNodeImpl.java:135)
> at
> org.apache.axiom.om.impl.llom.OMElementImpl.getNextOMSibling(OMElementImpl.java:310)
> Analysis:
> This could be a side effect of OMSourcedElement usage. I don't have a
> representative unit test.
> Solution:
> However I am going to add some additional trace and a slight accomodation in
> the code. There are several places
> where it is easy to ask the builder whether it is "complete" prior to calling
> builder.next.
> I will be committing a small change soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
