With 4 +1 binding votes, and 1 non-binding +1 vote, this vote passes. I'll promote the artifacts.
Colm. On Mon, Oct 26, 2015 at 12:13 PM, Alessio Soldano <[email protected]> wrote: > OK, got it. > I can live with the changes, here is my +1. > > Cheers > Alessio > > > On 26/10/15 12:19, Colm O hEigeartaigh wrote: > > Hi Alessio, > > Personally am I fine with minor (package) changes like this in the first > few revisions of a major release like 2.1.x. After this release, 2.1.x will > probably go into strict bug fix mode. Having said that, if you're unhappy > with this particular change, I don't mind reverting some of the changes in > the ws-security-dom module + respinning the release, just let me know asap! > > Colm. > > On Mon, Oct 26, 2015 at 11:11 AM, Alessio Soldano <[email protected]> > wrote: > >> OK, I asked by extending a CXF class (WSS4JInInterceptor) I was impacted >> by the change, as one of the refactored class (WSSecurityEngine) is >> returned in one of the WSS4JInterceptor protected methods. This said, this >> is not a major problem to me, just wanted to be sure this was considered. >> >> Cheers >> Alessio >> >> >> On 26/10/15 12:01, Colm O hEigeartaigh wrote: >> >> Hi Alessio, >> >> The changes are fairly minor and don't really impact on users of the >> library, the vast majority of which will pick up the release via CXF. There >> are no configuration changes in the release. The plan for 2.2.x is to pick >> up JDK8, so it won't really be a minor release. >> >> Colm. >> >> On Mon, Oct 26, 2015 at 10:51 AM, Alessio Soldano <[email protected]> >> wrote: >> >>> Hi Colm, >>> I'm wondering if is it really ok to have package refactorings and >>> constants moved to different class in a micro release. Are those changes >>> really required now or perhaps they would better fit into a minor (2.2.x) ? >>> >>> Cheers >>> Alessio >>> >>> >>> On 23/10/15 18:00, Colm O hEigeartaigh wrote: >>> >>>> This is a vote to release Apache WSS4J 2.1.4, which is a minor bug fix >>>> release. >>>> >>>> Artifacts: >>>> >>>> https://repository.apache.org/content/repositories/orgapachews-1031/ >>>> >>>> Source release: >>>> >>>> >>>> https://repository.apache.org/content/repositories/orgapachews-1031/org/apache/wss4j/wss4j/2.1.4/wss4j-2.1.4-source-release.zip >>>> >>>> Issues fixed: >>>> >>>> https://issues.apache.org/jira/browse/WSS/fixforversion/12333362/ >>>> >>>> +1 from me. >>>> >>>> Colm. >>>> >>>> >>>> -- >>>> Colm O hEigeartaigh >>>> >>>> Talend Community Coder >>>> http://coders.talend.com >>>> >>> >>> >>> -- >>> Alessio Soldano >>> Web Service Lead, JBoss >>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >> >> >> -- >> Colm O hEigeartaigh >> >> Talend Community Coder >> http://coders.talend.com >> >> >> >> -- >> Alessio Soldano >> Web Service Lead, JBoss >> >> > > > -- > Colm O hEigeartaigh > > Talend Community Coder > http://coders.talend.com > > > > -- > Alessio Soldano > Web Service Lead, JBoss > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com
