[
https://issues.apache.org/jira/browse/AXIOM-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146217#comment-15146217
]
Hudson commented on AXIOM-445:
------------------------------
SUCCESS: Integrated in axiom-trunk #2523 (See
[https://builds.apache.org/job/axiom-trunk/2523/])
AXIOM-445: Change return type of OMText#getDataHandler() to DataHandler instead
of Object. (veithen: rev 1730268)
*
axiom/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/common/serializer/pull/Navigator.java
*
axiom/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/mixin/AxiomTextSupport.aj
* axiom/axiom-api/src/main/java/org/apache/axiom/om/OMText.java
*
axiom/axiom-api/src/main/java/org/apache/axiom/om/impl/MTOMXMLStreamWriter.java
* axiom/axiom-compat/src/main/java/org/apache/axiom/om/impl/MIMEOutputUtils.java
*
axiom/axiom-compat/src/main/java/org/apache/axiom/om/impl/serialize/OMXMLReader.java
* axiom/axiom-compat/src/main/java/org/apache/axiom/om/util/TextHelper.java
*
axiom/axiom-jaxb/src/test/java/org/apache/axiom/om/ds/jaxb/JAXBOMDataSourceTest.java
* axiom/samples/src/test/java/org/apache/axiom/samples/MTOMSample.java
* axiom/src/site/markdown/release-notes/1.3.0.md
*
axiom/systests/old-tests/src/test/java/org/apache/axiom/attachments/ImageSampleTest.java
*
axiom/systests/old-tests/src/test/java/org/apache/axiom/om/impl/mtom/MTOMStAXSOAPModelBuilderTest.java
*
axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/builder/TestReadAttachmentBeforeRootPartComplete.java
*
axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/factory/TestCreateOMTextFromDataHandlerProvider.java
*
axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/sourcedelement/push/WriteDataHandlerProviderScenario.java
*
axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/sourcedelement/push/WriteDataHandlerScenario.java
*
axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap12/envelope/TestBuildWithAttachments.java
*
axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap12/mtom/TestBuilderDetach.java
> Ambiguously typed field & methods associated with OMText
> --------------------------------------------------------
>
> Key: AXIOM-445
> URL: https://issues.apache.org/jira/browse/AXIOM-445
> Project: Axiom
> Issue Type: Improvement
> Reporter: James Grahn
> Priority: Minor
>
> OMText has an ambiguously typed field "datahandler", which leads to
> ambiguously typed getters, setters, constructors, and factory methods
> (elsewhere).
> OMTextImpl's behavior (as of 1.2.10) requires that the "Object" argument be
> either a DataHandler or DataHandlerProvider. Any other object type will
> potentially result in a class cast exception within this class's own use.
> Moreover, this requirement is undocumented in the API Javadocs.
> Using properly typed field/constructor/getter/setter/factory methods would
> not only increase clarity to users and remove a potential ClassCastException,
> but also remove switch statements based upon instanceof.
> The field does have a comment which states the intent is "removing the
> dependency on javax.activation.DataHandler", but to what end? The import
> statement is included in the most recent versions of the OMTextImpl and
> there's a good chance the class would have to be present at runtime anyway.
> Furthermore, other classes within Axiom do require DataHandler as part of
> their interface.
> As this would be a change to the API, I assume any action on this would
> probably require waiting until a major version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
