[ 
https://issues.apache.org/jira/browse/WSS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171803#comment-15171803
 ] 

Christian Mäder commented on WSS-571:
-------------------------------------

Shall I only modify Merlin then and leave the Crypto interface as is?
Those downstream implementations you mention: Those don't inherit from 
CryptoBase, do they? Because if they did, nothing would break for them.

I had an implementation which would load the truststore with the keystore 
provider in case the truststore provider is not given, but decided otherwise. 
My thought went along the lines that it would require additional logic if one 
wants to use the default truststore provider, for example setting the relevant 
property to an empty string. For me, "having to set a property to enforce 
default behavior" was against my sense of good design, i.e. IMO it is not 
"logic" behavior when setting up a new project.
But I will have no regrets changing this if you think backwards compatible 
behavior is more favorable in this case.

> Truststore Provider
> -------------------
>
>                 Key: WSS-571
>                 URL: https://issues.apache.org/jira/browse/WSS-571
>             Project: WSS4J
>          Issue Type: New Feature
>            Reporter: Christian Mäder
>            Assignee: Colm O hEigeartaigh
>         Attachments: feature_truststoreprovider.diff
>
>
> This patch adds a truststore provider to Merlin.
> I needed this, because my truststore is software based, whereas my keystore 
> is hardware backed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to