deshankoswatte opened a new pull request #6: Improve thread safety of subclass ThreadLocalSecurityProvider. URL: https://github.com/apache/ws-wss4j/pull/6 - If a synchronized method is overridden in a subclass, the compiler does not require the overriding method to be synchronized. However, if the overriding method is not synchronized, the thread-safety of the subclass may be broken. As for [1]. - This PR improves the thread safety of ThreadLocalSecurityProvider by adding the synchronized keywords to the overridden synchronized methods. Fixes some of the alerts in [https://lgtm.com/projects/g/apache/ws-wss4j/alerts/?mode=list](https://lgtm.com/projects/g/apache/ws-wss4j/alerts/?mode=list). [1] - [https://help.semmle.com/wiki/display/JAVA/Non-synchronized+override+of+synchronized+method](https://help.semmle.com/wiki/display/JAVA/Non-synchronized+override+of+synchronized+method)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
