free-ice commented on a change in pull request #41:
URL: https://github.com/apache/ws-wss4j/pull/41#discussion_r717645145
##########
File path: ws-security-dom/src/main/java/org/apache/wss4j/dom/WSConstants.java
##########
@@ -191,17 +191,21 @@
/**
* Sets the {@link
- * org.apache.wss4j.dom.message.WSSecSignature#build(Document, Crypto,
WSSecHeader)
- * } or the {@link
- * org.apache.wss4j.dom.message.WSSecEncrypt#build(Document, Crypto,
WSSecHeader)
+ *org.apache.wss4j.dom.message.WSSecSignature#build(Crypto)
+ *} or the {@link
+ *org.apache.wss4j.dom.message.WSSecEncrypt#build(Crypto, SecretKey)
* } method to send the issuer name and the serial number of a certificate
to
* the receiver.
* <p/>
* In contrast to {@link #BST_DIRECT_REFERENCE} only the issuer name
* and the serial number of the signing certificate are sent to the
* receiver. This reduces the amount of data being sent. The encryption
* method uses the public key associated with this certificate to encrypt
- * the symmetric key used to encrypt data.
+ * the symmetric key used to encrypt data.
+ * The name format will
+ * delimit unicode characters with a '\' which is not compatible with
Microsoft's WCF stack.
Review comment:
Done
##########
File path: ws-security-dom/src/main/java/org/apache/wss4j/dom/WSConstants.java
##########
@@ -319,9 +323,31 @@
*/
public static final int ENDPOINT_KEY_IDENTIFIER = 14;
+
+ /**
+ *Sets the {@link
org.apache.wss4j.dom.message.WSSecSignature#build(Crypto)}
+ * or the {@link org.apache.wss4j.dom.message.WSSecEncrypt#build(Crypto,
SecretKey)}
+ * method to send the issuer name and the serial number of a certificate to
+ *the receiver.
Review comment:
Done
##########
File path:
ws-security-dom/src/main/java/org/apache/wss4j/dom/handler/WSHandlerConstants.java
##########
@@ -87,6 +87,8 @@ private WSHandlerConstants() {
* </li>
* <li><code>IssuerSerial</code> for {@link WSConstants#ISSUER_SERIAL}
* </li>
+ * <li><code>IssuerSerial</code> for {@link
WSConstants#ISSUER_SERIAL_QUOTE_FORMAT}
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
