For RequiredPartsBuilder, the String in question is returned from getAttributeNS which returns an empty String if there is no Attribute Namespace. That being said I did find one place in the code where a null check makes sense.
Colm. On Sun, Nov 14, 2021 at 4:19 AM Rob Leland <[email protected]> wrote: > > This is actually a set of changes from last year, Oct 8 2020, I didn't > realize I had read that far back through the commits trying determine 2.4.0 > changes: > commit 7923539117127296a65392f4c83ebd885386b7e4 > > The RequiredPartsBuilder change in particular does not seem to check for > null, so I would need to look at the change in a larger context to determine > if an issue was introduced. > > On Fri, Nov 12, 2021 at 4:40 AM Colm O hEigeartaigh <[email protected]> > wrote: >> >> What change are you referring to, can you point me to a line of code? >> Colm. >> >> On Tue, Nov 9, 2021 at 9:50 PM Rob Leland <[email protected]> wrote: >> > >> > Was the change from "".equals(var) to var.length evaluated for NPE errors? >> > The previous method NPE were avoided. >> > >> > On Tue, Nov 9, 2021, 09:33 Colm O hEigeartaigh <[email protected]> wrote: >> >> >> >> Thanks everyone, the vote passes with 6 +1 votes, at least 3 of them >> >> binding. >> >> >> >> Colm. >> >> >> >> On Mon, Nov 8, 2021 at 11:26 PM Sagara Gunathunga >> >> <[email protected]> wrote: >> >> > >> >> > +1 >> >> > >> >> > Thanks! >> >> > >> >> > On Tuesday, November 2, 2021, Colm O hEigeartaigh <[email protected]> >> >> > wrote: >> >> >> >> >> >> This is a vote to release Apache WSS4J 2.4.0. Even though this is a >> >> >> new major release, the changes are somewhat minimal - the main purpose >> >> >> of the release is to pick up a new major version of Apache Santuario >> >> >> (2.3.0). >> >> >> >> >> >> Git tag: https://github.com/apache/ws-wss4j/releases/tag/wss4j-2.4.0 >> >> >> Artifacts: >> >> >> https://repository.apache.org/content/repositories/orgapachews-1087/ >> >> >> >> >> >> +1 from me. >> >> >> >> >> >> Colm. >> >> >> >> >> >> --------------------------------------------------------------------- >> >> >> To unsubscribe, e-mail: [email protected] >> >> >> For additional commands, e-mail: [email protected] >> >> >> >> >> > >> >> > >> >> > -- >> >> > Sent from Gmail Mobile >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: [email protected] >> >> For additional commands, e-mail: [email protected] >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
