veithen commented on PR #343: URL: https://github.com/apache/ws-axiom/pull/343#issuecomment-1789788083
Basically your PR copies the code from `axiom-legacy-attachments` into a new module and replaces references to `javax` by `jakarta`. That's duplication because any change or bug fix to that code would need to be applied twice. Also, that change is rendered obsolete by one of @robertlazarski's commits which actually migrated `axiom-legacy-attachments` to the Jakarta APIs. His change makes sense because `axiom-legacy-attachments` is really just meant to be used by Axis2. Since Axis2 has now switched to the Jakarta APIs, we don't need a JavaEE version of `axiom-legacy-attachments` anymore. As for Spring-WS, a future version that reinstates Axiom support should not depend on `axiom-legacy-attachments` at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For additional commands, e-mail: dev-h...@ws.apache.org
