jrihtarsic commented on code in PR #260:
URL: https://github.com/apache/ws-wss4j/pull/260#discussion_r1452985909
##########
ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecSignature.java:
##########
@@ -898,6 +906,50 @@ private X509Certificate[] getSigningCerts() throws
WSSecurityException {
return certs;
}
+ /**
+ * The method returns EdDSA signature algorithm for public key type
(Ed25519 or Ed448).
+ *
+ * @param publicKey the public key to get the algorithm from
+ * @return the siganture algorithm (ED25519 or ED448) for the EdDSA public
key
+ * @throws WSSecurityException if the algorithm cannot be determined
+ */
+ public String getSigAlgorithmForEdDSAKey(PublicKey publicKey) throws
WSSecurityException {
Review Comment:
You are absolutely right. No need to be public. Now is fixed to private
static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org
For additional commands, e-mail: dev-h...@ws.apache.org
