ppkarwasz commented on code in PR #673:
URL: https://github.com/apache/ws-wss4j/pull/673#discussion_r3998956573
##########
ws-security-stax/src/main/java/org/apache/wss4j/stax/setup/WSSec.java:
##########
@@ -461,7 +462,7 @@ public static WSSSecurityProperties
validateAndApplyDefaultsToInboundSecurityPro
}
public static Schema loadWSSecuritySchemas() throws SAXException {
- SchemaFactory schemaFactory =
SchemaFactory.newInstance(XMLConstants.W3C_XML_SCHEMA_NS_URI);
+ SchemaFactory schemaFactory =
SecureSchemaFactory.newInstance(XMLConstants.W3C_XML_SCHEMA_NS_URI);
schemaFactory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING,
Boolean.TRUE);
Review Comment:
Setting `FSP` is no longer useful here.
##########
ws-security-common/src/test/java/org/apache/wss4j/common/util/SOAPUtil.java:
##########
Review Comment:
The `setNamespaceAware(true)` on line 51 can be removed and replaced with
`newNSInstance`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
