Setting this System property at ServletTransportManager does not seem right since this is needed in Synapse. What if we have the facility of removing the servlet transport in the future? Setting this property is not something to do with the servlet transport, but it is a system level thing, so it should be set at a system level.
On Thu, Mar 15, 2012 at 2:58 PM, <[email protected]> wrote: > Author: pradeep > Date: Thu Mar 15 05:28:11 2012 > New Revision: 122698 > URL: http://wso2.org/svn/browse/wso2?view=rev&revision=122698 > > Log: > fixing CARBON-11603 > > Modified: > > carbon/kernel/trunk/core/org.wso2.carbon.tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/transport/ServletTransportManager.java > > carbon/kernel/trunk/core/org.wso2.carbon.tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/valves/CarbonStuckThreadDetectionValve.java > > Modified: > carbon/kernel/trunk/core/org.wso2.carbon.tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/transport/ServletTransportManager.java > URL: > http://wso2.org/svn/browse/wso2/carbon/kernel/trunk/core/org.wso2.carbon.tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/transport/ServletTransportManager.java?rev=122698&r1=122697&r2=122698&view=diff > > ============================================================================== > --- > carbon/kernel/trunk/core/org.wso2.carbon.tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/transport/ServletTransportManager.java > (original) > +++ > carbon/kernel/trunk/core/org.wso2.carbon.tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/transport/ServletTransportManager.java > Thu Mar 15 05:28:11 2012 > @@ -21,6 +21,9 @@ > ServerConfigurationService serverConfigurationService = > CarbonTomcatServiceHolder.getServerConfigurationService(); > String portOffset = System.getProperty("portOffset", > > serverConfigurationService.getFirstProperty("Ports.Offset")); > + //setting the the retrieved ports.offset value as a system > propery, in case it was not defined. > + //NIO transport make use of this system property > + System.setProperty("portOffset",portOffset); > //There is a default value in carbon.xml, therefor not doing a > null check here > ServletTransportManager.portOffset = Integer.parseInt(portOffset); > ServletTransportManager.httpPort = > CarbonTomcatServiceHolder.getCarbonTomcatService().getPort("http") + > > Modified: > carbon/kernel/trunk/core/org.wso2.carbon.tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/valves/CarbonStuckThreadDetectionValve.java > URL: > http://wso2.org/svn/browse/wso2/carbon/kernel/trunk/core/org.wso2.carbon.tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/valves/CarbonStuckThreadDetectionValve.java?rev=122698&r1=122697&r2=122698&view=diff > > ============================================================================== > --- > carbon/kernel/trunk/core/org.wso2.carbon.tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/valves/CarbonStuckThreadDetectionValve.java > (original) > +++ > carbon/kernel/trunk/core/org.wso2.carbon.tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/valves/CarbonStuckThreadDetectionValve.java > Thu Mar 15 05:28:11 2012 > @@ -176,7 +176,7 @@ > } > } > > - private class MonitoredThread { > + private static class MonitoredThread { > > /** > * Reference to the thread to get a stack trace from background > task > _______________________________________________ > Carbon-commits mailing list > [email protected] > https://wso2.org/cgi-bin/mailman/listinfo/carbon-commits > -- *Afkham Azeez* Director of Architecture; WSO2, Inc.; http://wso2.com Member; Apache Software Foundation; http://www.apache.org/ * <http://www.apache.org/>** email: **[email protected]* <[email protected]>* cell: +94 77 3320919 blog: **http://blog.afkham.org* <http://blog.afkham.org>* twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> * linked-in: **http://lk.linkedin.com/in/afkhamazeez* * * *Lean . Enterprise . Middleware*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
