Constant interface is an anti-pattern. The proper fix would be to make this interface into a "final class" and then use the classname qualified constant, or static imports.
On Mon, Mar 26, 2012 at 8:44 PM, <[email protected]> wrote: > Author: samisa > Date: Mon Mar 26 11:14:29 2012 > New Revision: 123973 > URL: http://wso2.org/svn/browse/wso2?view=rev&revision=123973 > > Log: > More Sonar reported issues fixed > > Modified: > > carbon/kernel/trunk/core/org.wso2.carbon.utils/src/main/java/org/wso2/carbon/utils/component/xml/ComponentConstants.java > > Modified: > carbon/kernel/trunk/core/org.wso2.carbon.utils/src/main/java/org/wso2/carbon/utils/component/xml/ComponentConstants.java > URL: > http://wso2.org/svn/browse/wso2/carbon/kernel/trunk/core/org.wso2.carbon.utils/src/main/java/org/wso2/carbon/utils/component/xml/ComponentConstants.java?rev=123973&r1=123972&r2=123973&view=diff > > ============================================================================== > --- > carbon/kernel/trunk/core/org.wso2.carbon.utils/src/main/java/org/wso2/carbon/utils/component/xml/ComponentConstants.java > (original) > +++ > carbon/kernel/trunk/core/org.wso2.carbon.utils/src/main/java/org/wso2/carbon/utils/component/xml/ComponentConstants.java > Mon Mar 26 11:14:29 2012 > @@ -18,24 +18,24 @@ > public interface ComponentConstants { > > //OMElement local names > - public static final String ELE_DEPLOYERS = "deployers"; > - public static final String ELE_DEPLOYER = "deployer"; > - public static final String ELE_DIRECTORY = "directory"; > - public static final String ELE_EXTENSION = "extension"; > - > - public static final String ELE_HTTP_GET_REQUEST_PROCESSORS = > "httpGetRequestProcessors"; > - public static final String ELE_PROCESSOR = "processor"; > - public static final String ELE_ITEM = "item"; > - > - public static final String ELE_COMPONENT_BUILDERS = > "componentBuilders"; > - public static final String ELE_COMPONENT_BUILDER = "componentBuilder"; > - public static final String ELE_CLASS = "class"; > - public static final String ELE_ID = "id"; > + String ELE_DEPLOYERS = "deployers"; > + String ELE_DEPLOYER = "deployer"; > + String ELE_DIRECTORY = "directory"; > + String ELE_EXTENSION = "extension"; > + > + String ELE_HTTP_GET_REQUEST_PROCESSORS = "httpGetRequestProcessors"; > + String ELE_PROCESSOR = "processor"; > + String ELE_ITEM = "item"; > + > + String ELE_COMPONENT_BUILDERS = "componentBuilders"; > + String ELE_COMPONENT_BUILDER = "componentBuilder"; > + String ELE_CLASS = "class"; > + String ELE_ID = "id"; > > //namespaces > - public final static String NS_WSO2CARBON = " > http://products.wso2.org/carbon";; > + String NS_WSO2CARBON = "http://products.wso2.org/carbon";; > > - public static final String DEPLOYER_CONFIG = ELE_DEPLOYERS; > - public static final String HTTP_GET_REQUEST_PROCESSORS = > ELE_HTTP_GET_REQUEST_PROCESSORS; > + String DEPLOYER_CONFIG = ELE_DEPLOYERS; > + String HTTP_GET_REQUEST_PROCESSORS = ELE_HTTP_GET_REQUEST_PROCESSORS; > > } > _______________________________________________ > Commits mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/commits > -- *Afkham Azeez* Director of Architecture; WSO2, Inc.; http://wso2.com Member; Apache Software Foundation; http://www.apache.org/ * <http://www.apache.org/>** email: **[email protected]* <[email protected]>* cell: +94 77 3320919 blog: **http://blog.afkham.org* <http://blog.afkham.org>* twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> * linked-in: **http://lk.linkedin.com/in/afkhamazeez* * * *Lean . Enterprise . Middleware*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
